feat(proxy): allow setting allow-lan via API #824
Merged
+125
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]> Signed-off-by: Yuwei Ba <[email protected]>
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR exposes the allow-lan setting via the HTTP API by making it reloadable at runtime.
- Added an endpoint test to verify getting and setting
allow-lan - Made
allow_lanreloadable inInboundManager(withget_allow_lan/set_allow_lan) - Updated API handlers to include
allow_lanin GET / PATCH/configs
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| clash_lib/tests/api_tests.rs | New async test for GET and PATCH of allow-lan |
| clash_lib/src/config/internal/listener.rs | Removed outdated TODO comment on reloadability |
| clash_lib/src/app/inbound/network_listener.rs | Moved info! logs into spawned tasks |
| clash_lib/src/app/inbound/manager.rs | Added get_allow_lan / set_allow_lan and restart logic |
| clash_lib/src/app/api/handlers/config.rs | Included allow_lan in API GET and PATCH handlers |
Comments suppressed due to low confidence (2)
clash_lib/tests/api_tests.rs:64
- The
format!call uses a named placeholder{configs_url}without passing a corresponding argument, causing a compile error. Change it to a positional placeholder ({} {}) or supplyconfigs_url = configs_url.
"application/json' -d '{\"allow-lan\": false}}' {configs_url}",
clash_lib/src/app/api/handlers/config.rs:210
- Combining
if let Some(...) = ... && ...is invalid Rust syntax. Consider nesting or matching separately, e.g.if let Some(v) = payload.allow_lan { if v != inbound_manager.get_allow_lan().await { ... } }.
if let Some(allow_lan) = payload.allow_lan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge